Re: [RESEND PATCH 1/1] bitops.h: move out get_count_order[_long]() from __KERNEL__ scope

From: Al Viro
Date: Wed Aug 17 2016 - 13:21:42 EST


On Tue, Aug 16, 2016 at 03:46:22PM +0800, zijun_hu wrote:
> From: zijun_hu <zijun_hu@xxxxxxx>
>
> move out get_count_order[_long]() definitions from scope limited
> by macro __KERNEL__
>
> it not only make both functions available in wider region regardless
> of whether __KERNEL__ is defined but also keep original region for
> get_count_order() before the recent commit c513b4cd2fe9
> ("mm-vmalloc-fix-align-value-calculation-error-v2-fix-fix")

What the hell is anything without __KERNEL__ doing with linux/bitops.h in
the first place? IOW, why do we have those ifdefs at all?