Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain

From: Alexander Popov
Date: Tue Aug 16 2016 - 15:58:32 EST


On 15.08.2016 15:37, Paolo Bonzini wrote:
> On 15/08/2016 13:51, Alexander Popov wrote:
>> On 13.08.2016 09:20, Paolo Bonzini wrote:
>>> So just let the irqdomain know about your hypervisor and avoid the
>>> pointless indirection through function pointers, and only call
>>> arch_init_paravirq_domain in a file specific to your hypervisor.
>>
>> Paolo, I would like paravirq irq_domain to be useful for many hypervisors,
>> not only for one developed by Positive Technologies.
>
> If somebody else comes up with similar needs, leave the generalization
> of the code to them. The maintainers will surely remember. Without two
> users, there's a nonzero chance that the abstraction you have is not
> good enough, and actually gets in the way of the "second user".

Ok. I'll return with v2. Thank you.

Best regards,
Alexander