Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property

From: Guenter Roeck
Date: Mon Aug 15 2016 - 21:43:52 EST


On Mon, Aug 15, 2016 at 5:55 PM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:
> Hi Guenter,
>
> Looks good to me.
> I'll add the reference[1] information on patch description and applied it.
> [1] https://en.wikipedia.org/wiki/USB#Overview
>

Thanks!

Guenter

> Thanks,
> Chanwoo Choi
>
> On 2016ë 08ì 15ì 22:15, Guenter Roeck wrote:
>> From: Guenter Roeck <groeck@xxxxxxxxxxxx>
>>
>> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2
>> and USB3 connections on USB Type-C cables.
>>
>> Cc: Chris Zhong <zyw@xxxxxxxxxxxxxx>
>> Signed-off-by: Guenter Roeck <groeck@xxxxxxxxxxxx>
>> ---
>> Applies on top of extcon-next.
>>
>> include/linux/extcon.h | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
>> index ad7a1606a7f3..38d2c0dec2c1 100644
>> --- a/include/linux/extcon.h
>> +++ b/include/linux/extcon.h
>> @@ -107,12 +107,18 @@
>> * @type: integer (intval)
>> * @value: 0 (normal) or 1 (flip)
>> * @default: 0 (normal)
>> + * - EXTCON_PROP_USB_SUPERSPEED
>> + * @type: integer (intval)
>> + * @value: 0 (USB/USB2) or 1 (USB3)
>> + * @default: 0 (USB/USB2)
>> + *
>> */
>> #define EXTCON_PROP_USB_VBUS 0
>> #define EXTCON_PROP_USB_TYPEC_POLARITY 1
>> +#define EXTCON_PROP_USB_SUPERSPEED 2
>>
>> #define EXTCON_PROP_USB_MIN 0
>> -#define EXTCON_PROP_USB_MAX 1
>> +#define EXTCON_PROP_USB_MAX 2
>> #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1)
>>
>> /* Properties of EXTCON_TYPE_CHG. */
>>
>