Re: [PATCH v2 1/3] sas: provide stub implementations for scsi_is_sas_phy and sas_get_address

From: James Bottomley
Date: Mon Aug 15 2016 - 13:10:07 EST


On Mon, 2016-08-15 at 17:12 +0200, Johannes Thumshirn wrote:
> +static inline u64 sas_get_address(struct scsi_device *sdev)
> +{
> + return 0;
> +}

To be honest, we don't want this. We do want the code to fail to
compile if you ever use sas_get_address where you shouldn't because the
code will be incorrect at that point. If we could return an error,
fine, but we just return the address.

James