Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments"

From: Randy Dunlap
Date: Sun Aug 14 2016 - 15:09:46 EST


On 08/14/16 11:35, Jonathan Corbet wrote:
> On Thu, 04 Aug 2016 10:55:14 -0700
> Joe Perches <joe@xxxxxxxxxxx> wrote:
>
>>> Because Linus may still be reading source code on greenbar paper
>>> instead of color terminals with code syntax highlighting and
>>> appropriate font decorations.
>>>
>>> Link: http://lkml.kernel.org/r/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@xxxxxxxxxxxxxx
>>>
>>> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
>>> ---
>>> Documentation/CodingStyle | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>
>>> diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
>>> index 9a70ddd..19b2e9c 100644
>>> --- a/Documentation/CodingStyle
>>> +++ b/Documentation/CodingStyle
>>> @@ -461,9 +461,6 @@ When commenting the kernel API functions, please use the kernel-doc format.
>>> See the files Documentation/kernel-doc-nano-HOWTO.txt and scripts/kernel-doc
>>> for details.
>>>
>>> -Linux style for comments is the C89 "/* ... */" style.
>>> -Don't use C99-style "// ..." comments.
>>> -
>>> The preferred style for long (multi-line) comments is:
>>>
>>> /*
>>
>> ping?
>
> Sorry, I've not been ignoring this, I've just not yet worked up the
> courage to apply it. Yes, Linus said he's fine with C++-style comments,
> but I still expect some pushback when people start actually sending them.
> I don't quite feel a sense of community consensus on this one.
>
> Still, what the heck, I'll go ahead and apply it. We can always revert it
> when people start screaming :)

I like it, but like Linus said, we don't want people to send
patches just to "fix" the comment style.

--
~Randy