Re: [PATCH 3/3] lis3: SPI transport layer

[Geert Uytterhoeven]

Hi Daniel,

On Mon, Mar 23, 2009 at 12:51 AM, Daniel Mack <daniel@xxxxxxxx> wrote:
> Make use of the new abstraction layer and add a new transport layer for
> spi. Works fine on a PXA based board.
>
> Signed-off-by: Daniel Mack <daniel@xxxxxxxx>
> Acked-by: Pavel Machek <pavel@xxxxxx>
> Cc: Ãric Piel <eric.piel@xxxxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/hwmon/Kconfig         |   16 ++++++
>  drivers/hwmon/Makefile        |    1 +
>  drivers/hwmon/lis3lv02d_spi.c |  114 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 131 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/hwmon/lis3lv02d_spi.c
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index b84bf06..9d78ab4 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig

In the mean time, this has moved to drivers/misc/lis3lv02d/Kconfig

> @@ -895,6 +895,22 @@ config SENSORS_LIS3LV02D
>           Say Y here if you have an applicable laptop and want to experience
>           the awesome power of lis3lv02d.
>
> +config SENSORS_LIS3_SPI
> +       tristate "STMicroeletronics LIS3LV02Dx three-axis digital accelerometer (SPI)"
> +       depends on !ACPI && SPI_MASTER && INPUT

Is there any specific reason this option depends on !ACPI?
This hurts multi-platform kernels, supporting both OF and ACPI.

> +       default n
> +       help
> +         This driver provides support for the LIS3LV02Dx accelerometer connected
> +         via SPI. The accelerometer data is readable via
> +         /sys/devices/platform/lis3lv02d.
> +
> +         This driver also provides an absolute input class device, allowing
> +         the laptop to act as a pinball machine-esque joystick.
> +
> +         This driver can also be built as modules.  If so, the core module
> +         will be called lis3lv02d and a specific module for the SPI transport
> +         is called lis3lv02d_spi.
> +

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds