Re: [PATCH V3 2/4] clk: Combine DT binding doc for max77686 and max77802

From: Rob Herring
Date: Wed Aug 10 2016 - 14:41:18 EST


On Wed, Aug 10, 2016 at 4:40 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:
> Hi,
>
> On Tuesday 28 June 2016 04:58 PM, Laxman Dewangan wrote:
>>
>> Hi Rob,
>>
>> On Tuesday 21 June 2016 12:16 PM, Laxman Dewangan wrote:
>>>
>>>
>>> On Monday 20 June 2016 10:09 PM, Rob Herring wrote:
>>>>
>>>> On Fri, Jun 17, 2016 at 04:21:05PM +0530, Laxman Dewangan wrote:
>>>>>
>>>>>
>>>>>
>>>>> +
>>>>> Following properties should be presend in main device node of the MFD
>>>>> chip.
>>>>> Required properties:
>>>>
>>>> I'd expect to see compatible strings updated...
>>>>
>>>
>>> There is no separate compatible string for clock. The clock nodes is the
>>> parent node only and the compatible described in the parent DT binding doc.
>>>
>>>
>>> Do we also need to add same thing here?
>>
>>
>> Are you fine with the above? As there is no compatible string for clock
>> (clock does not have separate node), do I still need to add explicitly here?
>>
>
>
> Can you please help here to review? If required, I can rebase and re-send
> the patches.

It is fine.

Acked-by: Rob Herring <robh@xxxxxxxxxx>