Re: [PATCH] omapfb: omapfb-main: Remove deprecated create_singlethread_workqueue

[Tomi Valkeinen]

On 02/07/16 14:34, Tejun Heo wrote:
> On Sat, Jul 02, 2016 at 02:00:56PM +0530, Bhaktipriya Shridhar wrote:
>> The workqueue auto_update_work is involved in auto updating mode for
>> manual-update displays. omapfb driver uses a delayed work item to update
>> the display at a constant rate.
>>
>> Since these long-running work items aren't involved in memory reclaim in
>> any way, system_long_wq has been used.
> 
> Can you please explain why this is long-running?

It shouldn't be long-running. update() should only start the transfer to
the display.

Although if something is not right (the user sets the auto-update
frequency to too high), the work could end up waiting for the previous
update to finish...

It's a debugging feature, so maybe that's not an issue.

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature