Re: [PACTH v2] mmc: sdhci: Do not allow tuning procedure to be interrupted

From: Benson Leung
Date: Mon Aug 08 2016 - 12:17:25 EST


On Mon, Aug 8, 2016 at 9:11 AM, <robert.foss@xxxxxxxxxxxxx> wrote:
>
> From: Christopher Freeman <cfreeman@xxxxxxxxxx>
>
> wait_event_interruptible_timeout() will return early if the blocked
> process receives a signal, causing the driver to abort the tuning
> procedure and possibly leaving the controller in a bad state. Since the
> tuning command is expected to complete quickly (<50ms) and we've set a
> timeout, use wait_event_timeout() instead.
>
> Signed-off-by: Christopher Freeman <cfreeman@xxxxxxxxxx>
> Tested-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>
> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>

Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx>

Thanks Robert!



--
Benson Leung
Senior Software Engineer, Chrom* OS
bleung@xxxxxxxxxxxx