Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop

From: Greg KH
Date: Mon Aug 08 2016 - 09:43:10 EST


On Mon, Aug 08, 2016 at 03:32:15PM +0200, dirk.eibach@xxxxxxxx wrote:
> From: Dirk Eibach <dirk.eibach@xxxxxxxx>
>
> sc16is7xx_port_irq() is laid out as an endless loop. It will exit only
> when there is no more interrupt left to service. This not common
> practice.
> In our case it lead to some strange hangup situation when there was an
> unexpected XOFF-interrupt that could not be handled.
> So let's service interrupts only once and report XOFF-interrupts that
> should never happen since they are never enabled.
>
> Signed-off-by: Dirk Eibach <dirk.eibach@xxxxxxxx>
>
> Conflicts:
> drivers/tty/serial/sc16is7xx.c

Why are these 2 lines in here?