Re: [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle

From: Lee Jones
Date: Mon Aug 08 2016 - 09:38:32 EST


On Fri, 15 Jul 2016, Peter Chen wrote:

> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Signed-off-by: Peter Chen <peter.chen@xxxxxxx>
> ---
> drivers/mfd/qcom_rpm.c | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 2e44323..ecca115 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -538,6 +538,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
> }
>
> rpm->ipc_regmap = syscon_node_to_regmap(syscon_np);
> + of_node_put(syscon_np);
> if (IS_ERR(rpm->ipc_regmap))
> return PTR_ERR(rpm->ipc_regmap);
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog