Re: [RFC 0/4] tools lib traceevent: Install fixes

From: Jiri Olsa
Date: Sun Aug 07 2016 - 08:56:28 EST


On Fri, Aug 05, 2016 at 11:42:41AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 05, 2016 at 10:13:52AM -0400, Steven Rostedt escreveu:
> > On Tue, 2 Aug 2016 16:01:44 +0200
> > Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> > > > BTW, before we start making this ready for their own libraries, I'd
> > > > like to make some changes with the naming convention. Mainly with
> > > > event_format and format_field.
> > > >
> > > > Perhaps we should change them to pevent_event and pevent_field?
> > >
> > > right, it does not have any global prefix for public symbols
> > >
> > > I'd actualy expect something like 'traceevent_',
> > > but 'pevent' is ok as well I guess
> >
> > OK, what's the consensus here? Should we keep "pevent_" or switch to
> > the longer "traceevent_"?
>
> traceevent_ matches libtraceevent, so I think would be more obvious the
> association of code with the library.

+1 for traceevent_ ... makes more sense to me

jirka