RE: [RFC V2 PATCH 17/25] net/netpolicy: introduce netpolicy_pick_queue

From: Liang, Kan
Date: Fri Aug 05 2016 - 09:56:00 EST




>
> On Thu, Aug 4, 2016 at 12:36 PM, <kan.liang@xxxxxxxxx> wrote:
> > From: Kan Liang <kan.liang@xxxxxxxxx>
> >
> > To achieve better network performance, the key step is to distribute
> > the packets to dedicated queues according to policy and system run
> > time status.
> >
> > This patch provides an interface which can return the proper dedicated
> > queue for socket/task. Then the packets of the socket/task will be
> > redirect to the dedicated queue for better network performance.
> >
> > For selecting the proper queue, currently it uses round-robin
> > algorithm to find the available object from the given policy object
> > list. The algorithm is good enough for now. But it could be improved
> > by some adaptive algorithm later.
> >
> Seriously? You want to all of this code so we revert to TX queue selection by
> round robin?
>

I agree that the round robin is not an optimal algorithm.
For this series, we intends to provide a generic infrastructure for review.
For the algorithm parts, it's already in our TODO list. We will replace it later.

Thanks,
Kan