Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell()

From: Thomas Gleixner
Date: Thu Aug 04 2016 - 10:30:39 EST


On Thu, 4 Aug 2016, Sebastian Frias wrote:
> On 08/04/2016 12:05 PM, Thomas Gleixner wrote:
> (for what is worth, my patch was based on a recent 4.7 that does not has the
> code you mention above)

In future, please always check against mainline or the head of the relevant
maintainer tree.

> > So we better remove the masking in the xlate functions completely and let all
> > the offending device trees trip over the warning so they get eventually fixed.
>
> That's fine by me.
> If you want I can submit a patch that does what you want (if so, should I use
> "fixes" or not?), let me know.

If it is broken then it wants a fixes tag plus an explanation WHY it is
broken, what consequences the breakage has etc.

If it's just a regular code improvement then not.

Decide yourself.

Thanks,

tglx