[RFC PATCH 2/4] usb: typec: Do not check if connected when setting roles

From: Guenter Roeck
Date: Tue Aug 02 2016 - 16:35:54 EST


The connection status can change after the connection status was
checked. Leave it up to the driver to perform the necessary checks.

Signed-off-by: Guenter Roeck <groeck@xxxxxxxxxxxx>
---
drivers/usb/typec/typec.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/usb/typec/typec.c b/drivers/usb/typec/typec.c
index 0d0ebed..a0ae0d6 100644
--- a/drivers/usb/typec/typec.c
+++ b/drivers/usb/typec/typec.c
@@ -859,9 +859,6 @@ current_data_role_store(struct device *dev, struct device_attribute *attr,
return -EOPNOTSUPP;
}

- if (!port->connected)
- return size;
-
ret = match_string(typec_data_roles, ARRAY_SIZE(typec_data_roles), buf);
if (ret < 0)
return ret;
@@ -918,9 +915,6 @@ static ssize_t current_power_role_store(struct device *dev,
return -EIO;
}

- if (!port->connected)
- return size;
-
ret = match_string(typec_roles, ARRAY_SIZE(typec_roles), buf);
if (ret < 0)
return ret;
--
2.6.6