Re: [git pull] drm for v4.8

From: Jani Nikula
Date: Tue Aug 02 2016 - 11:46:25 EST


On Tue, 02 Aug 2016, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Aug 2, 2016 at 4:10 AM, Ville SyrjÃlÃ
> <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
>>
>> I have a couple of pending PSR patches you may want to try as well,
>> if i915.enable_psr=0 helps.
>
> Yes. i915.enable_psr=0 seems to make the bad flickering go away.
>
> I'll try your git trees out later, but what exactly changed with
> regards to psr lately? It's set as a "dangerous" option, and even just
> clearing it caused
>
> Setting dangerous option enable_psr - tainting kernel
>
> which seems entirely bogus.

The warning comes from kernel/params.c for module_param_named_unsafe()
which has no way of knowing which values are safe, and complains if the
option is set at all.

BR,
Jani.

--
Jani Nikula, Intel Open Source Technology Center