Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro

From: Randy Dunlap
Date: Tue Aug 02 2016 - 11:40:56 EST


On 08/02/16 05:51, Mauro Carvalho Chehab wrote:
> Em Tue, 2 Aug 2016 20:01:34 +0800
> Baole Ni <baolex.ni@xxxxxxxxx> escreveu:
>
>> I find that the developers often just specified the numeric value
>> when calling a macro which is defined with a parameter for access permission.
>> As we know, these numeric value for access permission have had the corresponding macro,
>> and that using macro can improve the robustness and readability of the code,
>> thus, I suggest replacing the numeric parameter with the macro.
>
> Gah!
>
> A patch series with 1285 patches with identical subject!
>
> Please don't ever do something like that. My inbox is not trash!
>
> Instead, please group the changes per subsystem, and use different
> names for each patch. Makes easier for people to review.
>
> also, you need to send the patches to the subsystem mainatiner, and
> not adding a random list of people like this:
>
> To: gregkh@xxxxxxxxxxxxxxxxxxx, maurochehab@xxxxxxxxx, mchehab@xxxxxxxxxxxxx, mchehab@xxxxxxxxxx, m.chehab@xxxxxxxxxxx, m.szyprowski@xxxxxxxxxxx, kyungmin.park@xxxxxxxxxxx, k.kozlowski@xxxxxxxxxxx
>
> Btw, use *just* the more recent email of the maintainer, instead of
> spamming trash to all our emails (even to the ones that we don't use
> anymore!
>
> I'll just send all those things to /dev/null until you fix your
> email sending process.
>
+1285

There are people at Intel who know about things like this.

--
~Randy