include/linux/cec-funcs.h:1280: suspicious expression ?

From: David Binderman
Date: Mon Aug 01 2016 - 06:25:09 EST


Hello there,

include/linux/cec-funcs.h:1280:50: warning: logical âandâ applied to
non-boolean constant [-Wlogical-op]

Source code is

msg->msg[4] = ui_cmd->channel_identifier.major && 0xff;

Maybe better code

msg->msg[4] = ui_cmd->channel_identifier.major & 0xff;

Regards

David Binderman