Re: [PATCH 4/4] x86/efi: Allocate a trampoline if needed in efi_free_boot_services()

From: H. Peter Anvin
Date: Mon Aug 01 2016 - 01:07:58 EST


On 07/26/16 15:55, Andy Lutomirski wrote:
> + /*
> + * Nasty quirk: if all sub-1MB memory is used for boot
> + * services, we can get here without having allocated the
> + * real mode trampoline. It's too late to hand boot services
> + * memory back to the memblock allocator, so instead
> + * try to reclaim a single page if needed.
> + *

This comment makes no sense. Nowhere is there a dependency on a single
page, and this refers to allocation, not reclaim...

-hpa