Re: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

From: Stephen Hemminger
Date: Fri Jul 29 2016 - 17:16:25 EST


On Thu, 28 Jul 2016 11:15:19 +0300
Amir Levy <amir.jer.levy@xxxxxxxxx> wrote:

> + /* pad short packets */
> + if (unlikely(skb->len < ETH_ZLEN)) {
> + int pad_len = ETH_ZLEN - skb->len;
> +
> + /* The skb is freed on error */
> + if (unlikely(skb_pad(skb, pad_len))) {
> + cleaned_count += frame_count;
> + continue;
> + }
> + __skb_put(skb, pad_len);
> + }

Packets should be padded on transmit, not on receive??