Re: [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction tracepoints

From: Steven Rostedt
Date: Wed Jul 27 2016 - 11:24:19 EST


On Wed, 27 Jul 2016 10:51:03 -0400
Janani Ravichandran <janani.rvchndrn@xxxxxxxxx> wrote:

> Add zone information to an existing tracepoint in compact_zone(). Also,
> add a new tracepoint at the end of the compaction code so that latency
> information can be derived.
>
> Signed-off-by: Janani Ravichandran <janani.rvchndrn@xxxxxxxxx>
> ---

>
> + trace_mm_compaction_try_to_compact_pages_end(rc, *contended);
> +

Again, I'm not to thrilled about tracepoints just being added to track
the length of function calls. We have function graph tracer for that.

-- Steve


> return rc;
> }
>