Re: [PATCH] cfag12864b: Remove deprecated create_singlethread_workqueue

From: Tejun Heo
Date: Tue Jul 26 2016 - 13:01:36 EST


On Tue, Jul 26, 2016 at 10:23:00PM +0530, Bhaktipriya Shridhar wrote:
> @@ -257,7 +256,6 @@ void cfag12864b_disable(void)
> if (cfag12864b_updating) {
> cfag12864b_updating = 0;
> cancel_delayed_work(&cfag12864b_work);
> - flush_workqueue(cfag12864b_workqueue);

It should be converted to cancel_delayed_work_sync(); otherwise,
nothing guarantees that the work item is finished.

Thanks.

--
tejun