Re: [PATCH v2 02/10] userns: Add per user namespace sysctls.

From: Eric W. Biederman
Date: Mon Jul 25 2016 - 20:15:15 EST


"Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> writes:

> Limit per userns sysctls to only be opened for write by a holder
> of CAP_SYS_RESOURCE.
>
> Add all of the necessary boilerplate for having per user namespace
> sysctls.

> @@ -141,6 +215,7 @@ void free_user_ns(struct user_namespace *ns)
>
> do {
> parent = ns->parent;
> + retire_userns_sysctls(ns);
^^^^^^^^^^ Unfortunately it is not safe to call a sleeping function here
so this part needs to be taken back to the drawing board.

Which means this change gets has to wait for next cycle.
> #ifdef CONFIG_PERSISTENT_KEYRINGS
> key_put(ns->persistent_keyring_register);
> #endif

Eric