Re: [PATCH] add u64 number parser

From: Bart Van Assche
Date: Fri Jul 22 2016 - 21:47:52 EST


On 07/22/16 17:23, James Smart wrote:
+ buf = kmalloc(len + 1, GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+ memcpy(buf, s->from, len);
+ buf[len] = '\0';

Hello James,

Have you considered to combine the above kmalloc() and memcpy() calls into a single kasprintf(GFP_KERNEL, "%.*s", len, s->from) call?

Bart.