Re: [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*()

From: Sergei Shtylyov
Date: Thu Jul 21 2016 - 14:46:16 EST


Hello.

On 07/21/2016 09:41 PM, tom.ty89@xxxxxxxxx wrote:

From: Tom Yan <tom.ty89@xxxxxxxxx>

1. Removed a repeated bit masking in ata_mselect_control()
2. Moved `wce`/`d_sense` assignment below the page validity checks
3. Added/Removed empty lines where appropriate

Signed-off-by: Tom Yan <tom.ty89@xxxxxxxxx>

Perhaps Tejun is OK with that, but if you ask me doing 1 task per patch is a better practice.

[...]

MBR, Sergei