Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t

From: Vivien Didelot
Date: Thu Jul 21 2016 - 14:19:09 EST


Hi Cong,

Cong Wang <xiyou.wangcong@xxxxxxxxx> writes:

> On Thu, Jul 21, 2016 at 9:42 AM, Vivien Didelot
> <vivien.didelot@xxxxxxxxxxxxxxxxxxxx> wrote:
>> Change the ageing_time type in br_set_ageing_time() from u32 to what it
>> is expected to be, i.e. a clock_t.
>
> You also need to change struct switchdev_attr:
>
> struct switchdev_attr {
> struct net_device *orig_dev;
> enum switchdev_attr_id id;
> u32 flags;
> void *complete_priv;
> void (*complete)(struct net_device *dev, int err, void *priv);
> union {
> struct netdev_phys_item_id ppid; /* PORT_PARENT_ID */
> u8 stp_state; /* PORT_STP_STATE */
> unsigned long brport_flags; /* PORT_BRIDGE_FLAGS */
> u32 ageing_time; /* BRIDGE_AGEING_TIME */
> bool vlan_filtering; /*
> BRIDGE_VLAN_FILTERING */
> } u;
> };

Already changed in net/master as of eabfdda93477
("net: switchdev: change ageing_time type to clock_t").

Thanks,

Vivien