Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

From: Lars Melin
Date: Tue Jul 19 2016 - 04:30:21 EST


On 2016-07-19 13:40, Kristian Evensen wrote:

I guess I can match on the VID/PID in usbnet, but won't it be cleaner
to add a new bind() function (in cdc_ether) which matches the two PIDs
and leave usbnet as is? Or am I misunderstanding how to add this
functionality to usbnet?


Matching on the usb id is probably not a great idea, there is more id's
than the two you have found and there is also more than two non-unique mac addresses.

Example:

0200FFAAAAAA 19d2:1589/1592/1595
020CE70B0102 19d2:1040/1048/1405

You can easily find them by googling them, without colon separators you
will find them in verbose lsusb listings, with colons you will find them in dmesg pastings.

I would probably have found more dupes if users had refrained from using the stupid usbdevices cmd which removes almost all interesting info from device listings in internet foras.

/Lars