Re: [RCF 1/3] hwmon: Add ads1118 driver

From: kbuild test robot
Date: Sat Jul 16 2016 - 13:23:13 EST


Hi,

[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on v4.7-rc7 next-20160715]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Joshua-Clayton/hwmon-add-driver-for-TI-ADS1118/20160716-082056
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: x86_64-randconfig-x001-201629 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All warnings (new ones prefixed by >>):

drivers/hwmon/ads1118.c: In function 'ads1118_get_cfg':
>> drivers/hwmon/ads1118.c:421:22: warning: unused variable 'node' [-Wunused-variable]
struct device_node *node;
^~~~

vim +/node +421 drivers/hwmon/ads1118.c

405 ads->channel_data[i].cfg &= ~(BIT(ADS1118_PULL_UP));
406 }
407 #endif
408
409 static void ads1118_temp_chan_enable(struct ads1118 *ads)
410 {
411 struct ads_channel *chan = &ads->channel_data[ADS1118_TEMP_CHAN];
412 unsigned int rate = ads->ref->rates[ADS1118_DEFAULT_DR];
413
414 chan->cfg = ADS1118_TEMP_CFG;
415 ads1118_chan_set_rate(ads, chan, rate);
416 chan->enabled = true;
417 }
418
419 static int ads1118_get_cfg(struct ads1118 *ads)
420 {
> 421 struct device_node *node;
422
423 #ifndef CONFIG_OF
424 return -EINVAL;
425 #else
426 if (!ads->dev->of_node
427 || !of_get_next_child(ads->dev->of_node, NULL))
428 return -EINVAL;
429

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data