Re: [PATCH v2] clkdev: add devm_of_clk_get()

From: Kuninori Morimoto
Date: Thu Jul 07 2016 - 23:24:47 EST



Hi Michael

Thank you for your feedback

> > struct clk *clk_get(struct device *dev, const char *con_id)
> > {
> > ...
> > if (dev) {
> > clk = __of_clk_get_by_name(dev->of_node, dev_id, con_id);
> > ~~~~~~~~~~~~
> > ...
> > }
> > }
> >
> > I would like to select specific device_node.
>
> Do you have access to the struct device that you want to target? Can you
> pass that device into either clk_get or devm_clk_get?

If my understanding was correct, I think I can't.
In below case, "sound_soc" has its *dev, but "cpu" and "codec" doesn't
have *dev, it has node only. Thus, we are using of_clk_get() for these now.

clk = of_clk_get(cpu, xxx);
clk = of_clk_get(codec, xxx);

sound_soc {
...
cpu {
...
=> clocks = <&xxx>;
};
codec {
...
=> clocks = <&xxx>;
};
};