Re: [PATCH v3 01/21] backports: move legacy and SmPL patch application into helper

[Johannes Berg]

On Thu, 2016-07-07 at 02:10 +0200, Luis R. Rodriguez wrote:
> On Mon, Jul 04, 2016 at 11:33:03AM +0200, Johannes Berg wrote:
> > On Tue, 2014-11-11 at 00:14 -0800, Luis R. Rodriguez wrote:
> > > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> > > 
> > > This allows us to extend how backports uses patches for
> > > different types of applications. This will later be used
> > > for kernel integration support, for example.
> > > 
> > > This should have no functional change.
> > 
> > Obviously this patch was applied a long time ago,
> 
> Geesh yes over 2 year ago.

:)

> > but you lied - it has a functional change:
> > 
> > > +ÂÂÂÂÂÂÂÂif process.returncode != 0:
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂif not args.verbose:
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂlogwrite("Failed to apply changes from %s" %
> > > print_name)
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfor line in output:
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂlogwrite('> %s' % line)
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂraise Exception('Patch failed')
> > 
> > vs.
> > 
> > > -ÂÂÂÂÂÂÂÂif process.returncode != 0:
> > > -ÂÂÂÂÂÂÂÂÂÂÂÂif not args.verbose:
> > > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂlogwrite("Failed to apply changes from %s" %
> > > print_name)
> > > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfor line in output:
> > > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂlogwrite('> %s' % line)
> > > -ÂÂÂÂÂÂÂÂÂÂÂÂreturn 2
> > 
> > This had a major impact on the devel/git-tracker.py tool.
> 
> Sorry about that, is there an easy fix for it? Is there a test
> we can do to avoid further regressions against the tracker ?
> 

Luca has a fix.

johannes