Re: Reported regressions for 4.7 as of Sunday, 2016-06-19

From: Josh Boyer
Date: Tue Jul 05 2016 - 12:31:17 EST


On Wed, Jun 22, 2016 at 11:57 AM, Quinn Tran <quinn.tran@xxxxxxxxxx> wrote:
> Johannes, Martin,
>
> Based on the screen shot/call trace, it looks like this adapter is not using MSIX. It defaulted back to MSI or INTx interrupt. The code made an assumption of MSIX is available. There is no point in go through that code segment.
>
> Can you try this work around? Itâs untested. Thanks.
>
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index 5649c20..e033ecb 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2548,7 +2548,7 @@ void qla24xx_process_response_queue(struct scsi_qla_host *vha,
> if (!vha->flags.online)
> return;
>
> - if (rsp->msix->cpuid != smp_processor_id()) {
> + if (rsp->msix && (rsp->msix->cpuid != smp_processor_id())) {
> /* if kernel does not notify qla of IRQ's CPU change,
> * then set it here.
> */

Did this wind up going into an official commit somewhere?

josh