Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

From: Kalle Valo
Date: Tue Jul 05 2016 - 09:11:53 EST


Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> writes:

> The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added
> interface") attempted to fix an issue when a new AP interface is added.
>
> But the patch didn't check the return value of the functions doing the
> firmware calls and returned an error even if the functions didn't fail.
>
> This prevents the network device to be registered properly, so fix it.
>
> Fixes: commit 7311ea850079 ("mwifiex: fix AP start problem for newly added interface")
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

The fixes line should be:

Fixes: 7311ea850079 ("mwifiex: fix AP start problem for newly added interface")

I can fix that before I apply the patch.

--
Kalle Valo