Re: [PATCH v3 01/21] backports: move legacy and SmPL patch application into helper

[Johannes Berg]

On Tue, 2014-11-11 at 00:14 -0800, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> 
> This allows us to extend how backports uses patches for
> different types of applications. This will later be used
> for kernel integration support, for example.
> 
> This should have no functional change.

Obviously this patch was applied a long time ago, but you lied - it has
a functional change:

> +ÂÂÂÂÂÂÂÂif process.returncode != 0:
> +ÂÂÂÂÂÂÂÂÂÂÂÂif not args.verbose:
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂlogwrite("Failed to apply changes from %s" %
> print_name)
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfor line in output:
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂlogwrite('> %s' % line)
> +ÂÂÂÂÂÂÂÂÂÂÂÂraise Exception('Patch failed')

vs.

> -ÂÂÂÂÂÂÂÂif process.returncode != 0:
> -ÂÂÂÂÂÂÂÂÂÂÂÂif not args.verbose:
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂlogwrite("Failed to apply changes from %s" %
> print_name)
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfor line in output:
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂlogwrite('> %s' % line)
> -ÂÂÂÂÂÂÂÂÂÂÂÂreturn 2

This had a major impact on the devel/git-tracker.py tool.

johannes