Re: [PATCH net-next V4 0/6] switch to use tx skb array in tun

[Jason Wang]

On 2016å06æ30æ 23:45, Michael S. Tsirkin wrote:
> On Thu, Jun 30, 2016 at 02:45:30PM +0800, Jason Wang wrote:
> > >Hi all:
> > >
> > >This series tries to switch to use skb array in tun. This is used to
> > >eliminate the spinlock contention between producer and consumer. The
> > >conversion was straightforward: just introdce a tx skb array and use
> > >it instead of sk_receive_queue.
> > >
> > >A minor issue is to keep the tx_queue_len behaviour, since tun used to
> > >use it for the length of sk_receive_queue. This is done through:
> > >
> > >- add the ability to resize multiple rings at once to avoid handling
> > >   partial resize failure for mutiple rings.
> > >- add the support for zero length ring.
> > >- introduce a notifier which was triggered when tx_queue_len was
> > >   changed for a netdev.
> > >- resize all queues during the tx_queue_len changing.
> > >
> > >Tests shows about 15% improvement on guest rx pps:
> > >
> > >Before: ~1300000pps
> > >After : ~1500000pps
> Acked-by: Michael S. Tsirkin<mst@xxxxxxxxxx>
>
> Acked-from-altitude: 34697 feet.

Wow, thanks a lot!