Re: [PATCH] usb: serial: update CH34x driver in drivers/usb/serial

From: Greg KH
Date: Thu Jun 23 2016 - 22:39:20 EST


On Thu, Jun 23, 2016 at 06:47:54PM -0700, tech@xxxxxxxxxxxxxxx wrote:
> The old driver for usb-serial chips ch34x which submitted by kernel volunteer
> Frank A Kingswood <frank@xxxxxxxxxxxxxxxxxxxxxxxxxx> is too old to use, and the
> driver has bugs when receiving chracters, thus after communicating with the author
> we decide to revoke the old driver ch341.c and submit the new one ch34x.c.

"revoke"? Why not just fix the bugs in the existing one instead? That
would be a much smaller patch, and much easier to review.

> Add the relevant details to Documentation/usb/usb-serial.txt.
> Change the relevant files Kconfig and Makefile in drivers/usb/serial.
>
> Signed-off-by: WCH Tech Group <tech@xxxxxxxxxxxxxxx>

This has to be a person, it can not be a company, or any other anonymous
email address, sorry. Same with your "From:" address.

thanks,

greg k-h