Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()

[Julian Calaby]

Hi All,

On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt
<luisbg@xxxxxxxxxxxxxxx> wrote:
> The common format to check if a function returned an error pointer is to
> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
>
> Also, if there was an error returning -EINVAL instead of -1 is more
> appropriate.

These two changes could be argued to be separate changes deserving of
their own patches.

> Signed-off-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>

However if everyone else is ok with that, this is:

Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/