Re: [PATCH v3 5/8] scripts: add Linux .cocciconfig for coccinelle

From: Luis R. Rodriguez
Date: Tue Jun 21 2016 - 20:13:48 EST


On Tue, Jun 21, 2016 at 11:12:54PM +0200, Julia Lawall wrote:
> On Tue, 21 Jun 2016, Nicolas Palix (LIG) wrote:
>
> > Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit :
> > > Help Coccinelle when used against Linux with a set of sensible defaults
> > > options for Linux. This hints to coccinelle git can be used for 'git grep'
> > > queries over coccigrep. A timeout of 200 seconds should suffice for now.
> > >
> > > If you use idutils you can override for 'make coccicheck' by using the
> > > SPFLAGS option as follows:
> > >
> > > First build the index, for example:
> > > mkid -s
> > >
> > > Pick the cocci file you wnat to work with:
> > > export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
> > >
> > > Then run coccicheck:
> > > $ make coccicheck V=1 MODE=report SPFLAGS="--use-idutils ID"
> > >
> > > Coccinelle supports reading .cocciconfig from different directories,
> > > the later one overriding the previous reads in the following order:
> > >
> > > o Your current user's home directory is processed first
> > > o Your directory from which spatch is called is processed next
> > > o The directory provided with the --dir option is processed last, if used
> > >
> > > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> > Acked-by: Nicolas Palix <nicolas.palix@xxxxxxx>
>
> Hmm, I can see at least some advantages to encouraging people to do it the
> Coccinelle way, with the Coccinelle script rather than mkid directly.
> Then, if we need some other features specific to Coccinelle, we can just
> add them.

I can simply document that if users are used to using their own
target output file, and if they wanted it to be used by coccinelle
simply symlinking .id-utils.index to it would enable coccinelle
to pick it up by default.

If that is done, would the new .cocciconfig not override though?

Luis