Re: [PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in driver probe

From: Doug Anderson
Date: Tue Jun 21 2016 - 13:20:12 EST


Hi,

On Mon, Jun 20, 2016 at 9:34 PM, Tomasz Figa <tfiga@xxxxxxxxxxxx> wrote:
> From: Shunqian Zheng <zhengsq@xxxxxxxxxxxxxx>
>
> In .probe(), devm_kzalloc() is called with size == 0 and works only
> by luck, due to internal behavior of the allocator and the fact
> that the proper allocation size is small. Let's use proper value for
> calculating the size.
>
> Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi slaves")
>
> Signed-off-by: Shunqian Zheng <zhengsq@xxxxxxxxxxxxxx>
> Signed-off-by: Tomasz Figa <tfiga@xxxxxxxxxxxx>
> ---
> drivers/iommu/rockchip-iommu.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>