Re: [PATCH 3/3] mmc: mmc: fix switch timeout issue caused by jiffies precision

From: Ulf Hansson
Date: Tue Jun 21 2016 - 09:16:30 EST


On 19 May 2016 at 10:47, Chaotian Jing <chaotian.jing@xxxxxxxxxxxx> wrote:
> with CONFIG_HZ=100, the precision of jiffies is 10ms, and the
> generic_cmd6_time of some card is also 10ms. then, may be current
> time is only 5ms, but already timed out caused by jiffies precision.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@xxxxxxxxxxxx>

Thanks, applied for next!

Kind regards
Uffe

> ---
> drivers/mmc/core/mmc_ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
> index 32de144..ad6e979 100644
> --- a/drivers/mmc/core/mmc_ops.c
> +++ b/drivers/mmc/core/mmc_ops.c
> @@ -534,7 +534,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
> timeout_ms = MMC_OPS_TIMEOUT_MS;
>
> /* Must check status to be sure of no errors. */
> - timeout = jiffies + msecs_to_jiffies(timeout_ms);
> + timeout = jiffies + msecs_to_jiffies(timeout_ms) + 1;
> do {
> /*
> * Due to the possibility of being preempted after
> --
> 1.8.1.1.dirty
>