Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit

From: Arnd Bergmann
Date: Tue Jun 21 2016 - 07:40:29 EST


On Monday, June 20, 2016 9:12:50 PM CEST Martin K. Petersen wrote:
> >>>>> "Arnd" == Arnd Bergmann <arnd@xxxxxxxx> writes:
>
> As sector_t can be 32-bit wide, this adds a cast to 'u64' and prints
> that with the correct format. The change to use no_printk()
>
> [...]
>
> + dprintk("wd7000_biosparam: dev=%s, size=%lld, ",
> + bdevname(bdev, b), (s64)capacity);
>
> s64?
>
> Why not unsigned long long like we usually do with sector_t?

The printk() was using %d as the format string, printing it
as a signed number, so I did not change it.

Using %llu makes sense though, I've resent it like that.

Arnd