Re: [PATCH 1/4] sched/fair: Introduce sched_entity::dont_balance

From: Peter Zijlstra
Date: Mon Jun 20 2016 - 11:43:15 EST


On Mon, Jun 20, 2016 at 02:15:11PM +0200, Jiri Olsa wrote:
> Adding dont_balance bool into struct sched_entity,
> to mark tasks which are rebalanced based on affinity.
>
> It's used only when REBALANCE_AFFINITY feature is
> switched on. The code functionality of this feature
> is introduced in following patch.
>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
> include/linux/sched.h | 2 ++
> kernel/sched/fair.c | 21 ++++++++++++++++++---
> kernel/sched/features.h | 1 +
> 3 files changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index dee41bf59e6b..0e6ac882283b 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1331,6 +1331,8 @@ struct sched_entity {
>
> u64 nr_migrations;
>
> + bool dont_balance;

Never use bool in structures.