Re: [PATCH] aio: Cleanup unnecessary test for nr_pages

From: Minfei Huang
Date: Mon Jun 20 2016 - 10:06:28 EST


Ping. Any comment is appreciate.

Thanks
Minfei

On 06/13/16 at 12:33P, Minfei Huang wrote:
> The variable nr_pages is always more than 1, because the size of
> structure aio_ring is bigger than 0. So remove unnecessary test for
> nr_page.
>
> Signed-off-by: Minfei Huang <mnghuan@xxxxxxxxx>
> ---
> fs/aio.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index fb8e45b..ec05137 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -450,8 +450,6 @@ static int aio_setup_ring(struct kioctx *ctx)
> size += sizeof(struct io_event) * nr_events;
>
> nr_pages = PFN_UP(size);
> - if (nr_pages < 0)
> - return -EINVAL;
>
> file = aio_private_file(ctx, nr_pages);
> if (IS_ERR(file)) {
> --
> 2.7.4 (Apple Git-66)
>