Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

[Srinivas Pandruvada]

On Fri, 2016-06-17 at 22:45 +0200, Jiri Kosina wrote:
> On Fri, 17 Jun 2016, Jiri Kosina wrote:
> 
> > > +struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device
> *dev,
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ uuid_le uuid, char
> *name)
> > > +{
> >Â
> > Should be static.
> 
> Actually, going deeper into the code and trying to untangle all theÂ
> dependencies, there are quite a few more in other ipc.c, hid-
> client.c,Â
> etc. Please fix that globally in the next iteration.
> 
Great. I ran sparse and identified few more. I will fix this is new
iteration.

One thing I am still wondering is that the current ISH model is built
in only. Some distros configure CONFIG_HID as module. So in Kconfig inÂ
drivers/hid/intel-ish-hid/, I need to add "select HID".
What do you think about this?

Unless you are in middle of review, I want to go ahead and send v2.


Thanks,
Srinivas

> Thanks,
> 
> --Â
> Jiri Kosina
> SUSE Labs
>