Re: [patch] crypto: drbg - fix an error code in drbg_init_sym_kernel()

From: Stephan Mueller
Date: Fri Jun 17 2016 - 05:23:10 EST


Am Freitag, 17. Juni 2016, 11:19:58 schrieb Stephan Mueller:

Hi Stephan,

> Am Freitag, 17. Juni 2016, 12:16:19 schrieb Dan Carpenter:
>
> Hi Dan,
>
> > We accidentally return PTR_ERR(NULL) which is success but we should
> > return -ENOMEM.
> >
> > Fixes: 355912852115 ('crypto: drbg - use CTR AES instead of ECB AES')
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Acked-by: Stephan Mueller <smueller@xxxxxxxxxx>
>
> That points to an error in the documentation of skcipher_request_alloc.

Apologies, that documentation issue has already been fixed in the
cryptodev-2.6 tree. I was looking at the vanilla 4.6 tree for the
documentation while I was preparing my patch.

Ciao
Stephan