Re: [PATCH v3 5/7] max8903: removes non zero validity checks on gpios.

From: Krzysztof Kozlowski
Date: Fri Jun 17 2016 - 02:35:53 EST


On 06/17/2016 07:00 AM, Chris Lapa wrote:
> From: Chris Lapa <chris@xxxxxxxxxxx>
>
> Prior to this commit a zero gpio was treated as invalid. Whereas
> gpio_is_valid() will treat a zero gpio as valid.
>
> This commit removes the confusion and explicity uses gpio_is_valid()

s/explicity/explicitly/

> throughout. Which in turn results in several of the error messages becoming
> redundant and thus removed.
>
> Signed-off-by: Chris Lapa <chris@xxxxxxxxxxx>
> ---
> drivers/power/max8903_charger.c | 125 ++++++++++++++++++----------------------
> 1 file changed, 55 insertions(+), 70 deletions(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Best regards,
Krzysztof