Re: [RESEND PATCH v11 1/4] gadget: Introduce the usb charger framework

From: Baolin Wang
Date: Fri Jun 17 2016 - 02:19:13 EST


Hi Felipe,

On 13 June 2016 at 23:13, Jun Li <jun.li@xxxxxxx> wrote:
> Hi
>
>> -----Original Message-----
>> From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-
>> owner@xxxxxxxxxxxxxxx] On Behalf Of Baolin Wang
>> Sent: Monday, June 13, 2016 4:47 PM
>> To: balbi@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; sre@xxxxxxxxxx;
>> dbaryshkov@xxxxxxxxx; dwmw2@xxxxxxxxxxxxx
>> Cc: robh@xxxxxxxxxx; m.szyprowski@xxxxxxxxxxx; ruslan.bilovol@xxxxxxxxx;
>> peter.chen@xxxxxxxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx; r.baldyga@xxxxxxxxxxx;
>> yoshihiro.shimoda.uh@xxxxxxxxxxx; lee.jones@xxxxxxxxxx; broonie@xxxxxxxxxx;
>> ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx; patches@xxxxxxxxxxxxxxxxxxxxxxxxxxx;
>> baolin.wang@xxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; linux-
>> usb@xxxxxxxxxxxxxxx; device-mainlining@xxxxxxxxxxxxxxxxxxxxxxxxx; linux-
>> kernel@xxxxxxxxxxxxxxx
>> Subject: [RESEND PATCH v11 1/4] gadget: Introduce the usb charger
>> framework
>>
>> This patch introduces the usb charger driver based on usb gadget that
>> makes an enhancement to a power driver. It works well in practice but that
>> requires a system with suitable hardware.
>>
>> The basic conception of the usb charger is that, when one usb charger is
>> added or removed by reporting from the usb gadget state change or the
>> extcon device state change, the usb charger will report to power user to
>> set the current limitation.
>>
>> The usb charger will register notifiees on the usb gadget or the extcon
>> device to get notified the usb charger state. It also supplies the
>> notification mechanism to userspace When the usb charger state is changed.
>>
>> Power user will register a notifiee on the usb charger to get notified by
>> status changes from the usb charger. It will report to power user to set
>> the current limitation when detecting the usb charger is added or removed
>> from extcon device state or usb gadget state.
>>
>> This patch doesn't yet integrate with the gadget code, so some functions
>> which rely on the 'gadget' are not completed, that will be implemented in
>> the following patches.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
>
> Reviewed-by: Li Jun <jun.li@xxxxxxx>
> Tested-by: Li Jun <jun.li@xxxxxxx>

Do you have any comments about this patchset, if not I will resend it
with testing by Li Jun (thanks for Jun reviewing and testing). Thanks.

>
>> ---
>> drivers/usb/gadget/Kconfig | 7 +
>> drivers/usb/gadget/udc/Makefile | 1 +
>> drivers/usb/gadget/udc/charger.c | 770
>> ++++++++++++++++++++++++++++++++++++++
>> include/linux/usb/charger.h | 191 ++++++++++
>> include/uapi/linux/usb/charger.h | 31 ++
>> 5 files changed, 1000 insertions(+)
>> create mode 100644 drivers/usb/gadget/udc/charger.c create mode 100644
>> include/linux/usb/charger.h create mode 100644
>> include/uapi/linux/usb/charger.h



--
Baolin.wang
Best Regards