Re: [v3,1/2] b43: Remove unused phy_a code

From: Kalle Valo
Date: Thu Jun 16 2016 - 11:56:26 EST


Michael BÃsch <m@xxxxxxx> writes:

> On Thu, 16 Jun 2016 15:23:37 +0000 (UTC)
> Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
>
>> Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>> > gcc-6 reports the following error with -Werror=unused-const-variable.
>> >
>> > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error:
>> > 'b43_phyops_a' defined but not used
>> >
>> > Per Michael BÃsch: "All a-phy code is usused", so remove it all,
>> > and move the remaining Type-G initialization code into phy_g.c.
>> >
>> > Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> [0-day test robot]
>> > Cc: Michael BÃsch <m@xxxxxxx>
>> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>>
>> Thanks, 2 patches applied to wireless-drivers-next.git:
>>
>> 9791333a840f b43: Remove unused phy_a code
>> afdfdc481ea9 b43: Completely remove support for phy_a
>
> Did anybody test this on any hardware? I think this should be tested
> on some G-PHY hardware, before it goes to Linus.

Larry tested these:

"These two patches have been tested on a BCM4318."

https://patchwork.kernel.org/patch/9154719/

--
Kalle Valo