Re: [RESEND RFT PATCH 2/2] mfd: max14577: Allow driver to be built as a module

From: Lee Jones
Date: Thu Jun 16 2016 - 10:21:56 EST


On Thu, 26 May 2016, Javier Martinez Canillas wrote:

> The driver's Kconfig symbol is a boolean but nothing prevents the driver
> to be built as a module instead of built-in. It is true that most system
> integrators will choose the latter but the config should not restrict it.
>
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>
> ---
>
> drivers/mfd/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index a49565cc1a6b..33d112f390fe 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -514,8 +514,8 @@ config MFD_88PM860X
> battery-charger under the corresponding menus.
>
> config MFD_MAX14577
> - bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support"
> - depends on I2C=y
> + tristate "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support"
> + depends on I2C
> select MFD_CORE
> select REGMAP_I2C
> select REGMAP_IRQ

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog