Re: [PATCH v10 03/14] usb: hcd.h: Add OTG to HCD interface

From: Alan Stern
Date: Tue Jun 14 2016 - 10:22:16 EST


On Tue, 14 Jun 2016, Roger Quadros wrote:

> +Alan
>
> On 10/06/16 16:07, Roger Quadros wrote:
> > The OTG core will use struct otg_hcd_ops to interface
> > with the HCD (Host Controller Driver).
> >
> > The main purpose of this interface is to avoid directly
> > calling HCD APIs from the OTG core as they
> > wouldn't be defined in the built-in symbol table if
> > CONFIG_USB is m.
> >
> > Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> > Acked-by: Peter Chen <peter.chen@xxxxxxx>
> > ---
> > include/linux/usb/hcd.h | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> > index 66fc137..7729c1f 100644
> > --- a/include/linux/usb/hcd.h
> > +++ b/include/linux/usb/hcd.h
> > @@ -400,6 +400,30 @@ struct hc_driver {
> >
> > };
> >
> > +/**
> > + * struct otg_hcd_ops - Interface between OTG core and HCD
> > + *
> > + * Provided by the HCD core to allow the OTG core to interface with the HCD

Add: * in case the OTG core is built-in and the HCD core is built as a module.

Otherwise, for patches 1, 3, and 12:

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Alan Stern