Re: [PATCH 44/48] clocksource: atmel-pit: allow unselecting ATMEL_PIT

From: Boris Brezillon
Date: Mon Jun 13 2016 - 15:04:29 EST


On Sat, 11 Jun 2016 12:53:51 +0200
Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> wrote:

> On 11/06/2016 at 11:43:54 +0200, Thomas Gleixner wrote :
> > On Sat, 11 Jun 2016, Alexandre Belloni wrote:
> >
> > > With the new TCB clocksource driver, atmel platforms are now able to boot
> > > without the PIT driver. Allow unselecting it.
> >
> > Yay! Thanks for doing this!
> >
>
> Sure! Can you still check the request_irq/free_irq in
> timer-atmel-tcbclksrc? I'm not sure whether this can work reliably or
> only because we are before SYSTEM_STATE=RUNNING.
> In the latter case, I have another way of doing that.
>

Sorry to put it back on the table, but shouldn't we consider adding
these irq_disable/enable_action() helpers?

--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com